Skip to content

muxrpcli@3 style help#4

Merged
dominictarr merged 1 commit intomasterfrom
help
May 13, 2019
Merged

muxrpcli@3 style help#4
dominictarr merged 1 commit intomasterfrom
help

Conversation

@dominictarr
Copy link
Copy Markdown
Contributor

@dominictarr dominictarr commented May 7, 2019

ahdinosaur
ahdinosaur suggested changes May 7, 2019
View reviewed changes
Copy link
Copy Markdown

@ahdinosaur ahdinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to add these logs? if so, instead of console.log and console.error can we use the built-in logger at ssb-server/plugins/logging.js?

Comment thread index.js
opts = opts || {}

if(!isString(opts.query)) return pull.values([])
console.error('search:', opts)
Copy link
Copy Markdown

@ahdinosaur ahdinosaur May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental log?

Comment thread index.js
pull(
search.query({query: opts.query}),
pull.drain(function (data) {
console.log('found:', data.key)
Copy link
Copy Markdown

@ahdinosaur ahdinosaur May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental log?

@dominictarr dominictarr merged commit ab8b33f into master May 13, 2019
@christianbundy christianbundy mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ahdinosaur ahdinosaur ahdinosaur requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dominictarr @ahdinosaur