Repository navigation
Fix gateway to use inverter ID - #3777
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ESP32 Gateway MQTT integration to include the inverter serial in control commands by deriving it from the entity ID suffix, aligning command routing with multi-inverter setups.
Changes:
- Track a mapping of entity suffix → full inverter serial during
automatic_config(). - Include
serialin JSON command payloads for select/number/switch-driven gateway commands. - Add unit tests for
build_command()serial handling and update gateway test fixtures to include_suffix_to_serial.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/predbat/gateway.py | Adds suffix→serial mapping, entity_id→serial extraction, and forwards serial into published commands / command payload JSON. |
| apps/predbat/tests/test_gateway.py | Adds/adjusts tests and fixtures to cover command payload serial behavior and new instance state. |
| .cspell/custom-dictionary-workspace.txt | Adds “mpxn” to project spelling dictionary. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.