Repository navigation
fix: handle null start/end times in basic_rates - #3722
Merged
Merged
Conversation
dict.get("start", "00:00:00") returns None when the key exists with
an explicit null value. Use `or` to fall back to "00:00:00" for both
missing and null start/end times in rate entries.
Fixes crash: AttributeError: 'NoneType' object has no attribute 'count'
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dict.get("start", "00:00:00")returnsNonewhen the key exists with an explicitnullvalue — the default only applies when the key is missing entirelyor "00:00:00"to fall back for both missing and null start/end times in rate entriesresolve_arg()which can returnNonein edge casesContext
Customer on
manual_v2energy provider with a flat export rate — the tariff wizard saved"start": null, "end": nullfor the flat rate entry, causing:Test plan
basic_ratestests still pass🤖 Generated with Claude Code