Skip to content

Fix sticky reserve floor on inverters without managed reserve SOC (e.g. SolisCloud) #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 3 commits into from
Apr 3, 2026
Merged

Fix sticky reserve floor on inverters without managed reserve SOC (e.g. SolisCloud) #3709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e1dfb4
Initial plan
Copilot Mar 31, 2026
0d24ba7
Fix SolisCloud sticky reserve: clamp adjust_reserve at reserve_min, a…
Copilot Mar 31, 2026
5caa936
Simplify sticky reserve fix: use reserve_min as planning floor for no…
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/predbat/inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ def __init__(self, base, id=0, quiet=False, rest_postCommand=None, rest_getData=
self.reserve_min = battery_min_soc

self.base.log("Reserve min: {}%, battery_min: {}%".format(self.reserve_min, dp0(battery_min_soc)))
if self.base.set_reserve_enable and self.inv_has_reserve_soc:
if (self.base.set_reserve_enable and self.inv_has_reserve_soc) or not self.inv_has_reserve_soc:
self.reserve_percent = self.reserve_min
else:
self.reserve_percent = self.reserve_percent_current
Comment on lines 474 to 478

Copilot AI Apr 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior change to set reserve_percent = reserve_min when inv_has_reserve_soc is False isn’t currently covered by a unit test. In apps/predbat/tests/test_inverter.py, all existing inverter instantiations use inverter_type=["GE"] (managed reserve), so this regression-prone path (e.g. inverter_type="SolisCloud" with a high/stale reserve sensor) isn’t asserted. Please add a test that constructs an inverter with inv_has_reserve_soc=False and verifies reserve_percent (and thus adjust_reserve’s clamp floor) follows set_reserve_min rather than the current sensor value.

Copilot uses AI. Check for mistakes.
Expand Down
9 changes: 7 additions & 2 deletions apps/predbat/tests/test_inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def test_adjust_charge_window(
return failed


def test_adjust_reserve(test_name, ha, inv, dummy_rest, prev_reserve, reserve, expect_reserve=None, reserve_min=4, reserve_max=100):
def test_adjust_reserve(test_name, ha, inv, dummy_rest, prev_reserve, reserve, expect_reserve=None, reserve_min=4, reserve_max=100, reserve_percent=None):
"""
Test
inv.adjust_reserve(self, reserve):
Expand All @@ -229,7 +229,12 @@ def test_adjust_reserve(test_name, ha, inv, dummy_rest, prev_reserve, reserve, e
if expect_reserve is None:
expect_reserve = reserve

inv.reserve_percent = reserve_min
# reserve_percent simulates the current planning floor (may differ from reserve_min for
# inverters where inv_has_reserve_soc is False, e.g. SolisCloud where the sensor can be "stuck" high)
if reserve_percent is None:
reserve_percent = reserve_min
inv.reserve_percent = reserve_percent
inv.reserve_min = reserve_min
inv.reserve_max = reserve_max

print("Test: {}".format(test_name))
Expand Down
Loading