GH-6206: Update tool callback guidance#6214
Open
YunKuiLu wants to merge 1 commit into
Open
Conversation
Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm not sure whether the maintainers want to add
tools(ToolCallback...)andtools(ToolCallbackProvider...)overloads. This PR does not add those APIs. Instead, it updates the exception message and documentation examples that currently point users toward deprecated or incorrect usage.Changes
MethodToolCallbackProviderexception message to suggest usingtools(toolSpec -> toolSpec.callbacks(...))instead of passing callbacks/providers directly totools(...).ToolCallbackandToolCallbackProviderinstances throughcallbacks(...).ToolCallingChatOptionsexample that passed an@Toolobject directly totoolCallbacks(...)by converting it withToolCallbacks.from(...).Tests
./mvnw -pl spring-ai-model -Dtest=MethodToolCallbackProviderTests testRelated #6206