Skip to content

GH-6026: Pass reasoning_content back to DeepSeek API in multi-turn conversations #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suryateja-g13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-6026: Pass reasoning_content back to DeepSeek API in multi-turn conversations #6189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...s/spring-ai-deepseek/src/main/java/org/springframework/ai/deepseek/DeepSeekChatModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,14 +430,17 @@ else if (message.getMessageType() == MessageType.ASSISTANT) {
}).toList();
}
Boolean isPrefixAssistantMessage = null;
if (message instanceof DeepSeekAssistantMessage
&& Boolean.TRUE.equals(((DeepSeekAssistantMessage) message).getPrefix())) {
isPrefixAssistantMessage = true;
String reasoningContent = null;
if (message instanceof DeepSeekAssistantMessage deepSeekMsg) {
if (Boolean.TRUE.equals(deepSeekMsg.getPrefix())) {
isPrefixAssistantMessage = true;
}
reasoningContent = deepSeekMsg.getReasoningContent();
}
String text = assistantMessage.getText();
Assert.state(text != null, "text must not be null");
return List.of(new ChatCompletionMessage(text, ChatCompletionMessage.Role.ASSISTANT, null, null,
toolCalls, isPrefixAssistantMessage, null));
toolCalls, isPrefixAssistantMessage, reasoningContent));
}
else if (message.getMessageType() == MessageType.TOOL) {
ToolResponseMessage toolMessage = (ToolResponseMessage) message;
Expand Down
38 changes: 38 additions & 0 deletions ...eek/src/test/java/org/springframework/ai/deepseek/DeepSeekChatCompletionRequestTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@

package org.springframework.ai.deepseek;

import java.util.List;

import org.junit.jupiter.api.Test;

import org.springframework.ai.chat.messages.UserMessage;
import org.springframework.ai.chat.prompt.Prompt;
import org.springframework.ai.deepseek.api.DeepSeekApi;

Expand Down Expand Up @@ -54,4 +57,39 @@ public void createRequestWithChatOptions() {
assertThat(request.temperature()).isEqualTo(99.9D);
}

@Test
public void reasoningContentIsPassedBackForDeepSeekAssistantMessage() {
var client = DeepSeekChatModel.builder().deepSeekApi(DeepSeekApi.builder().apiKey("TEST").build()).build();

DeepSeekAssistantMessage assistantMessage = new DeepSeekAssistantMessage.Builder().content("The answer is 42.")
.reasoningContent("I reasoned through the problem step by step.")
.build();

var prompt = new Prompt(
List.of(new UserMessage("What is the answer?"), assistantMessage, new UserMessage("Are you sure?")),
DeepSeekChatOptions.builder().model("deepseek-reasoner").build());

var request = client.createRequest(prompt, false);

assertThat(request.messages()).hasSize(3);
var assistantMsg = request.messages().get(1);
assertThat(assistantMsg.role()).isEqualTo(DeepSeekApi.ChatCompletionMessage.Role.ASSISTANT);
assertThat(assistantMsg.reasoningContent()).isEqualTo("I reasoned through the problem step by step.");
}

@Test
public void nullReasoningContentIsOmittedForPlainAssistantMessage() {
var client = DeepSeekChatModel.builder().deepSeekApi(DeepSeekApi.builder().apiKey("TEST").build()).build();

var prompt = new Prompt(List.of(new UserMessage("Hello"),
new org.springframework.ai.chat.messages.AssistantMessage("Hi!"), new UserMessage("How are you?")),
DeepSeekChatOptions.builder().model("deepseek-chat").build());

var request = client.createRequest(prompt, false);

assertThat(request.messages()).hasSize(3);
var assistantMsg = request.messages().get(1);
assertThat(assistantMsg.reasoningContent()).isNull();
}

}
Loading