fix ToolCallAdvisor: correct per-round observations in streaming mode#6185
Open
tzolov wants to merge 1 commit into
Open
fix ToolCallAdvisor: correct per-round observations in streaming mode#6185tzolov wants to merge 1 commit into
tzolov wants to merge 1 commit into
Conversation
- Refactor ToolCallAdvisor streaming to create individual observations per LLM round instead of spanning all rounds. - Simplifies the streaming flow by replacing publish()-based multicast with aggregateChatClientResponse().concatWith() chain. - Updates DefaultAroundAdvisorChain to skip outer observation for streaming ToolAdvisor instances. Related to spring-projects#5167 spring-projects#6017 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5167
Related to #6017