GH-6120: Add REQUIRED constant to ToolChoiceBuilder in DeepSeek and MiniMax APIs#6157
Open
suryateja-g13 wants to merge 1 commit into
Open
Conversation
…Max APIs Adds the missing `REQUIRED` tool_choice constant that forces the model to call at least one tool without specifying which one, aligning with the OpenAI spec. Fixes: spring-projects#6120 Signed-off-by: Gorre Surya <suryateja.g13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REQUIREDconstant toToolChoiceBuilderinDeepSeekApiandMiniMaxApiREQUIREDforces the model to call at least one tool, but allows it to choose which onetool_choice: "required"is a valid valueFixes: #6120
Test plan
./mvnw -pl models/spring-ai-deepseek,models/spring-ai-minimax install -DskipTestsDeepSeekApi.ChatCompletionRequest.ToolChoiceBuilder.REQUIREDMiniMaxApi.ChatCompletionRequest.ToolChoiceBuilder.REQUIRED