Remove SpringBeanToolCallbackResolver and toolNames() API#6155
Draft
tzolov wants to merge 1 commit into
Draft
Conversation
Remove implicit Spring bean tool resolution by name in favour of explicit ToolCallback registration. Deletes SpringBeanToolCallbackResolver, removes toolNames()/defaultToolNames() from ChatClient, ChatClient.Builder, and all model-specific options builders, and removes spring.ai.*.chat.tool-names auto-configuration properties. Closes spring-projects#2399, spring-projects#2617, spring-projects#2632, spring-projects#2667 Resolves spring-projects#6154 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
tzolov
force-pushed
the
remove-spring-bean-tool-resolution
branch
from
563e9f7 to
509f285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove implicit Spring bean tool resolution by name in favour of explicit ToolCallback registration.
Deletes SpringBeanToolCallbackResolver, removes toolNames()/defaultToolNames() from ChatClient, ChatClient.Builder, and all model-specific options builders, and removes spring.ai.*.chat.tool-names auto-configuration properties.
Resolves #6154
Closes #2399, #2617, #2632, #2667