Repository navigation
fix(menubar): a take on Today's mic shows on the Models section's Dictation row - #636
Merged
Merged
Conversation
…tation row The Dictation row read its takes from a hand-written list of the container's Voice Inputs. Today's composer got its own in #624, after the list was written in #604, and never joined it: a take held on Today's mic read as Idle, and so did its Proofread Pass after release. The container now builds every Voice Input with makeVoiceInput(), which registers it in voiceInputs, and modelActivity() reads that. A source-shape test fails if the container builds one anywhere else.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
spokvulcan
pushed a commit
that referenced
this pull request
Oct 11, 2026
🤖 I have created a release *beep* *boop* --- ## [1.19.0](v1.18.0...v1.19.0) (2026-10-11) ### Features * **companion:** Today marks the step under way, shortens links, and lets Inbox items be ticked off ([#632](#632)) ([0e838bf](0e838bf)) * **companion:** Today's Chat shows the day's moments as cards you can act on ([#635](#635)) ([9e64c6b](9e64c6b)) ### Bug Fixes * **companion:** a repeating must-do ticked off counts as done, in its slot ([#634](#634)) ([011778a](011778a)) * **companion:** Today's Tomorrow keeps a task's time, and Later and Move to Today leave a repeating series alone ([#637](#637)) ([d3f38c6](d3f38c6)) * **menubar:** a take on Today's mic shows on the Models section's Dictation row ([#636](#636)) ([95e51b1](95e51b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The menu's Models section reads the Dictation row's Listening and Transcribing from the container's Voice Inputs. Its hand-written list, written in #604, missed Today's, added in #624.
Every Voice Input in the container now comes from one factory, which registers it:
The four Voice Inputs take the same arguments as before.
modelActivity()no longer creates the lazy ones it reads on the menu's first open: it reads only those made.Not in this PR: the onboarding's Dictation chapter builds its own Voice Input in its view, outside the container. It has no Proofread Pass, and its Whisper decode shows through the shared engine.
Evidence
MenuModelsSectionTestsfail:MenuModelsSectionTestsandLoadedModelsTests: 8 passed. Whole target: 3,631 passed, 0 failed, 7 skipped.scripts/check.shpasses.Merge Danger
Door: two-way
Wiring only: no stored data, settings or API. A revert puts the list back.
Blast Radius: menu
The Models section's Dictation row. The four Voice Inputs are built with the same arguments, now in one place.