This repository was archived by the owner on Mar 25, 2023. It is now read-only.
Fix bug in 'updateDocs' when latest version has no 'content/casts'#171
Open
milesrichardson wants to merge 1 commit intomasterfrom
Open
Fix bug in 'updateDocs' when latest version has no 'content/casts'#171milesrichardson wants to merge 1 commit intomasterfrom
milesrichardson wants to merge 1 commit intomasterfrom
Conversation
- Since latest version (as of v0.3.0) does not include the 'content/casts' root, but the code includes it as part of the 'paths.asciinema' root, the script was failing when copying the "latest" version of asciinema from the archive directory, since it didn't exist - To fix this, change the thrown error to a printed warning instead, since this should be tolerable
Contributor
|
This PR will soon no longer be relevant in this repository. See #192. If it is still needed, please raise it again in the parent monorepo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
update-docsscript ofcontent-scripts, which caused it to fail on any subsequent runs after merging of #160 (which included a latest version missing asciinemas)Merging this is non-urgent, but we just need this fix before the next time we run
yarn run update-docs(which is manual for now).