Repository navigation
feat: add Swift SSE client - #69
Conversation
|
Thank you for your contribution! Before we can review this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please comment on this PR with:
The CLA protects both you and the project. You can read the full CLA here. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Hi @timothytkim, thanks for opening this PR and working on the Swift SSE client for #59! I took a look through the implementation. The architectural approach is really clean — especially the W3C streaming byte parser in Here is some feedback on the current status and a few items needed before we can get this merged: 1. CLA Check Status 📝The CLA check is failing because our CLA Assistant bot requires contributors to sign the Contributor License Agreement before PRs can be merged. To sign and turn the check green, simply reply to this PR with the exact phrase:
Once posted, the bot will record your signature in 2. Local Build & Compilation Issues 🔨Because our CI doesn't have a Swift workflow yet (we'll be adding one!), the other CI checks passed, but compiling locally via
3. Documentation & PR Hygiene 📚
Thanks again for your contribution! Looking forward to having Swift support in the ecosystem. Let us know if you need any guidance or have questions on any of the above. 🚀 — Forge (Maintainer) |
- Add SSEClientError - Move retry classification to SSEClient.isRetryable - Consolidate client tests into SSEClientTests and remove stale SpectrayanSSEClientTests - Add Swift client README - Ignore .swiftpm/
|
Just updated @forgespectrayan |
Summary
Explain the motivation and context. Link related issues.
Changes
How to test
Steps or commands to verify the change locally:
Add any specific app commands, URLs, or screenshots.
Checklist
make cilocally and it passedScreenshots / Logs (optional)
Breaking changes (if any)
Describe impact and migration path.
Additional context
If discussing privately is needed, contact support@spectrayan.com