Repository navigation
fix(ruby): keep the packageName prompt description to one line so the quickstart input stays visible - #44
Closed
AshGodfrey wants to merge 1 commit into
Closed
fix(ruby): keep the packageName prompt description to one line so the quickstart input stays visible#44AshGodfrey wants to merge 1 commit into
AshGodfrey wants to merge 1 commit into
Conversation
… quickstart input stays visible
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Restores the Ruby packageName prompt description to one line so the quickstart input stays visible; a focused rollback of a recently added warning that remains documented in the changelog.
Re-trigger cubic
Contributor
Author
|
Folding this into the CLI generator bump instead; the CLI test assertion is what needs updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby
packageNameconfig description is rendered inside the CLI quickstart prompt. The sentence added in #38 about case-only names makes it wrap to three lines in the prompt, which is more than a prompt hint should carry.Restore the one-line description. The case-only limitation stays documented in the #38 changelog entry.
The CLI side is handled separately in speakeasy-api/speakeasy#2137, which fixes the prompt sizing bug that a multi-line description exposed, so this change is not needed to unblock the CLI bump.
Validation: