Linter: create rule to to add syntactical sugar when then is set to false #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Contributor
Author
|
@jviotti , any comments? |
jviotti
reviewed
Aug 7, 2025
Signed-off-by: karan-palan <[email protected]>
Contributor
Author
|
@jviotti , any comments? |
jviotti
reviewed
Aug 11, 2025
jviotti
reviewed
Aug 11, 2025
jviotti
reviewed
Aug 11, 2025
jviotti
reviewed
Aug 11, 2025
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Contributor
Author
|
Resolved conflicts and removed default |
jviotti
reviewed
Aug 21, 2025
jviotti
reviewed
Aug 21, 2025
Signed-off-by: karan-palan <[email protected]>
jviotti
reviewed
Aug 22, 2025
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
jviotti
reviewed
Aug 28, 2025
| const SchemaFrame &, const SchemaFrame::Location &, | ||
| const SchemaWalker &, const SchemaResolver &) const | ||
| -> SchemaTransformRule::Result override { | ||
| return contains_any( |
Member
There was a problem hiding this comment.
Can you make use of the new macros? You can rebase from main and see how I refactored the other rules! More specifically, the new macros will let you highlight if specifically on the Registry
Signed-off-by: karan-palan <[email protected]>
Contributor
Author
|
@jviotti ready for review |
jviotti
reviewed
Sep 19, 2025
jviotti
reviewed
Sep 19, 2025
jviotti
reviewed
Sep 19, 2025
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Contributor
Author
|
@jviotti used the new macros and resolved conflicts, ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1897 (comment)