Conversation
|
Can this be merged? |
|
Do you have thoughts @taldcroft on the change in display with the sun position and momentum monitor since I retired the ops page completely? I was basically waiting for a review from you too as I figured you are more of a customer than Javier. |
|
@jeanconn - sorry, I confess I didn't read the details of the description and was convinced by the title that this was purely a packaging PR. I see now that this appears to be a very large PR with lots of code updates that are big enough that GitHub doesn't even show a diff. So this PR is going to need some review and discussion in person. In any case, for sure we do not want those new monitor enable/disables showing up in the standard flight version. This is a lot of noise from the perspective of basically all the current users. |
|
Sounds good. And yeah, I mostly added them (Sun Position Monitor / Momentum Monitor) to the standard config so we wouldn't forget to have discussion about changes. Sounds like it worked! |
|
Looking a bit more at ACE_hourly_avg.npy and how it is used Line 18 in 5a71044 it looks like the file is really being used as a lookup for ACE fluence patterns? Do you agree @taldcroft ? So it isn't ridiculous that things don't look horrible for the percentile predictions that come out of this even if the file has not been updated in modern times. May or may not be worth an update. |
Description
Package arc as a Python package.
Basically, this was moving stuff around, adding Python wrapper scripts for the perl scripts, and adding a pyproject.toml. While at it, I also removed direct SKA dependence within the code so if the testing user has SKA set to /proj/sot/ska, they won't accidentally write back into SKA/data/arc3, for example. I also removed arc_ops.cfg and set the flight config to include Momentum and Sun Position Monitor in the display, though of course that is negotiable.
Interface impacts
Functional testing
Running in https://cxc.cfa.harvard.edu/mta/ASPECT/arc3_pip_test/index.html
For a "new" installation for testing, this still requires that one copy over ACE.h5, GOES.h5, hrc_shield.h5, and ACE_hourly_avg.npy, into the new data directory. I don't know how ACE_hourly_avg.npy is used and if it should get an update, a retirement, or moved into package data if it is static.