Skip to content

Package as a Python package and simplify config#96

Draft
jeanconn wants to merge 27 commits intomasterfrom
package
Draft

Package as a Python package and simplify config#96
jeanconn wants to merge 27 commits intomasterfrom
package

Conversation

@jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Mar 2, 2026

Description

Package arc as a Python package.

Basically, this was moving stuff around, adding Python wrapper scripts for the perl scripts, and adding a pyproject.toml. While at it, I also removed direct SKA dependence within the code so if the testing user has SKA set to /proj/sot/ska, they won't accidentally write back into SKA/data/arc3, for example. I also removed arc_ops.cfg and set the flight config to include Momentum and Sun Position Monitor in the display, though of course that is negotiable.

Interface impacts

Functional testing

Running in https://cxc.cfa.harvard.edu/mta/ASPECT/arc3_pip_test/index.html

For a "new" installation for testing, this still requires that one copy over ACE.h5, GOES.h5, hrc_shield.h5, and ACE_hourly_avg.npy, into the new data directory. I don't know how ACE_hourly_avg.npy is used and if it should get an update, a retirement, or moved into package data if it is static.

@jeanconn jeanconn changed the title WIP: Package as a Python package Package as a Python package Mar 3, 2026
@jeanconn jeanconn marked this pull request as ready for review March 11, 2026 16:17
@jeanconn jeanconn requested review from javierggt and taldcroft March 11, 2026 16:18
Copy link

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as part of the skare3 PR

@taldcroft
Copy link
Member

Can this be merged?

@jeanconn
Copy link
Contributor Author

Do you have thoughts @taldcroft on the change in display with the sun position and momentum monitor since I retired the ops page completely? I was basically waiting for a review from you too as I figured you are more of a customer than Javier.

@taldcroft
Copy link
Member

@jeanconn - sorry, I confess I didn't read the details of the description and was convinced by the title that this was purely a packaging PR.

I see now that this appears to be a very large PR with lots of code updates that are big enough that GitHub doesn't even show a diff. So this PR is going to need some review and discussion in person.

In any case, for sure we do not want those new monitor enable/disables showing up in the standard flight version. This is a lot of noise from the perspective of basically all the current users.

@jeanconn
Copy link
Contributor Author

Sounds good. And yeah, I mostly added them (Sun Position Monitor / Momentum Monitor) to the standard config so we wouldn't forget to have discussion about changes. Sounds like it worked!

@jeanconn jeanconn changed the title Package as a Python package Package as a Python package and simplify config Mar 24, 2026
@jeanconn jeanconn marked this pull request as draft March 25, 2026 16:52
@jeanconn
Copy link
Contributor Author

Looking a bit more at ACE_hourly_avg.npy and how it is used

dat = np.load(filename)

it looks like the file is really being used as a lookup for ACE fluence patterns? Do you agree @taldcroft ? So it isn't ridiculous that things don't look horrible for the percentile predictions that come out of this even if the file has not been updated in modern times. May or may not be worth an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants