Skip to content

[cleaner] set mapper to initializing during prepper work#4357

Merged
TurboTurtle merged 1 commit into
sosreport:mainfrom
pmoravec:sos-pmoravec-cleaner-prepper-initializing
Jun 8, 2026
Merged

[cleaner] set mapper to initializing during prepper work#4357
TurboTurtle merged 1 commit into
sosreport:mainfrom
pmoravec:sos-pmoravec-cleaner-prepper-initializing

Conversation

@pmoravec

@pmoravec pmoravec commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

.. and call generate_compiled_regexes at the end. This prevents repetitive and redundant calling the method for each found item.

Resolves: #4356
Closes: #4357


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

.. and call generate_compiled_regexes at the end. This prevents
repetitive and redundant calling the method for each found item.

Resolves: sosreport#4356
Closes: sosreport#4357

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4357
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec

pmoravec commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

This is a regression since 4.11.[0-1]ish time (I didnt perform precise dissect), so I would like to have it merged into 4.11.2 - could either @TurboTurtle or @arif-ali review it, pretty please?

Reproducer is trivial:

for i in $(seq 1 50); do
    for j in $(seq 2 51); do
        echo 20.40.${i}.${j} host${i}-${j} host${i}-${j}.some.domain.com
    done
done > /etc/hosts

sos report -o networking,host --batch --build

.. and call rm -rf /etc/sos/cleaner/; sos clean on the generated sosreport directory.

@TurboTurtle TurboTurtle added Kind/Enhancement Status/Needs Review This issue still needs a review from project members Kind/cleaner cleaner component of sos labels Jun 4, 2026
@pmoravec pmoravec requested review from TurboTurtle and arif-ali June 8, 2026 06:44
@pmoravec

pmoravec commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Kindly asking @arif-ali and/or @TurboTurtle for a review - I would like to fix this regression till the next release scheduled for the next week.

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Status/Needs Review This issue still needs a review from project members labels Jun 8, 2026
@TurboTurtle TurboTurtle merged commit 1f6661b into sosreport:main Jun 8, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind/cleaner cleaner component of sos Kind/Enhancement Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cleaner] Slow prepping /etc/hosts

2 participants