[foreman] Allow to set size limit instead of hardcoding it#4103
Open
pablomh wants to merge 1 commit into
Open
Conversation
Allow the possibility to provide the `sizelimit` value using the `log_size` option. Set it by default (when no option is provided) to the current value (500). Signed-off-by: Pablo Mendez Hernandez <pablomh@redhat.com>
TurboTurtle
requested changes
Aug 15, 2025
Member
TurboTurtle
left a comment
There was a problem hiding this comment.
log_size is always set to some value, aside from when a user passes --all-logs, where we override it to None.
This would make it so that this collection is always following log_size, and also mean we only limit to 500mb when we are otherwise requesting we don't do any size limiting, which isn't desired.
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the possibility to provide the
sizelimitvalue using thelog_sizeoption.Set it by default (when no option is provided) to the current value (500).
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines