Skip to content

fix(Android, Stack v5): set needsCustomLayoutForChildren to true for StackHost #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kligarski merged 1 commit into from
Jun 24, 2026
+9 −0
Merged

fix(Android, Stack v5): set needsCustomLayoutForChildren to true for StackHost #4200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/gamma/stack/host/StackHostViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ class StackHostViewManager :
super.onDropViewInstance(view)
}

/**
* StackScreens need to be positioned by **native** layout **initiated by** StackHost's layout
* from Yoga but **not by using the dimensions provided to StackScreen by Yoga directly**.
* Otherwise, we receive outdated layout from Yoga, e.g. after an orientation change.
* If we set this flag to true, we receive incorrect measure but layout won't be called. Next
* native layout traversal will remeasure the view and apply correct layout.
*/
override fun needsCustomLayoutForChildren() = true

companion object {
const val REACT_CLASS = "RNSStackHost"
}
Expand Down
Loading