Skip to content

chore(Android, Stack v5): update showAsAction test with icon configuration#4198

Open
kligarski wants to merge 1 commit into
mainfrom
@kligarski/stack-v5-android-add-icon-to-show-as-action
Open

chore(Android, Stack v5): update showAsAction test with icon configuration#4198
kligarski wants to merge 1 commit into
mainfrom
@kligarski/stack-v5-android-add-icon-to-show-as-action

Conversation

@kligarski

Copy link
Copy Markdown
Contributor

Description

Adds icon configuration to showAsAction test. This is a follow-up to #4101 and #4105.

Note

The bug with orientation changes described in #4101 (comment) is still present. This doesn't impact the test added in this PR and will be handled separately.

Changes

  • add option to change icon for menu items
  • update scenario

Visual documentation

Screen_recording_20260622_115145.mp4

Test plan

Run test-stack-toolbar-menu-show-as-action-android.

Checklist

  • Included code example that can be used to test this change.
  • For visual changes, included screenshots / GIFs / recordings documenting the change.
  • Ensured that CI passes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Android Stack v5 single-feature test for showAsAction to also exercise menu item icon configuration, making the WITH_TEXT variants verifiable and expanding the manual scenario accordingly.

Changes:

  • Added icon selection for toolbar menu items in the showAsAction SFT UI (props path + command path).
  • Expanded the test scenario markdown to cover icon/overflow behavior and WITH_TEXT visual differences.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/src/tests/single-feature-tests/stack-v5/test-stack-toolbar-menu-show-as-action-android/scenario.md Updates manual test steps/notes to include icon interactions and WITH_TEXT verification.
apps/src/tests/single-feature-tests/stack-v5/test-stack-toolbar-menu-show-as-action-android/index.tsx Adds icon options to slot configuration and to setToolbarMenuItemOptions command inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from @kligarski/stack-v5-android-refactor to main June 24, 2026 09:53
@kligarski kligarski force-pushed the @kligarski/stack-v5-android-add-icon-to-show-as-action branch from 54118ca to 78191e3 Compare June 24, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants