chore(Android, Stack v5): update showAsAction test with icon configuration#4198
Open
kligarski wants to merge 1 commit into
Open
chore(Android, Stack v5): update showAsAction test with icon configuration#4198kligarski wants to merge 1 commit into
showAsAction test with icon configuration#4198kligarski wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Android Stack v5 single-feature test for showAsAction to also exercise menu item icon configuration, making the WITH_TEXT variants verifiable and expanding the manual scenario accordingly.
Changes:
- Added icon selection for toolbar menu items in the
showAsActionSFT UI (props path + command path). - Expanded the test scenario markdown to cover icon/overflow behavior and
WITH_TEXTvisual differences.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/src/tests/single-feature-tests/stack-v5/test-stack-toolbar-menu-show-as-action-android/scenario.md | Updates manual test steps/notes to include icon interactions and WITH_TEXT verification. |
| apps/src/tests/single-feature-tests/stack-v5/test-stack-toolbar-menu-show-as-action-android/index.tsx | Adds icon options to slot configuration and to setToolbarMenuItemOptions command inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t0maboro
approved these changes
Jun 22, 2026
54118ca to
78191e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds icon configuration to
showAsActiontest. This is a follow-up to #4101 and #4105.Note
The bug with orientation changes described in #4101 (comment) is still present. This doesn't impact the test added in this PR and will be handled separately.
Changes
Visual documentation
Screen_recording_20260622_115145.mp4
Test plan
Run
test-stack-toolbar-menu-show-as-action-android.Checklist