Refactor/communication between audio and js thread#942
Open
maciejmakowski2003 wants to merge 82 commits intomainfrom
Open
Refactor/communication between audio and js thread#942maciejmakowski2003 wants to merge 82 commits intomainfrom
maciejmakowski2003 wants to merge 82 commits intomainfrom
Conversation
added 30 commits
February 2, 2026 16:21
poneciak57
reviewed
Mar 2, 2026
poneciak57
requested changes
Mar 2, 2026
packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioBufferQueueSourceNode.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/core/IOSAudioRecorder.mm
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioBufferQueueSourceNode.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioContext.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Show resolved
Hide resolved
mdydek
requested changes
Mar 2, 2026
Contributor
mdydek
left a comment
mdydek
left a comment
There was a problem hiding this comment.
make sure to align with current formatter, because some files are wrongly formatted and git diff is going crazy
packages/react-native-audio-api/common/cpp/audioapi/core/analysis/AnalyserNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/BiquadFilterNode.h
Show resolved
Hide resolved
…github.com:software-mansion/react-native-audio-api into refactor/communication-between-audio-and-js-thread
poneciak57
requested changes
Mar 3, 2026
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/test/src/utils/TripleBufferTest.cpp
Show resolved
Hide resolved
poneciak57
reviewed
Mar 4, 2026
packages/react-native-audio-api/common/cpp/audioapi/utils/TripleBuffer.hpp
Show resolved
Hide resolved
added 2 commits
March 5, 2026 07:43
…ith copyable types
poneciak57
approved these changes
Mar 5, 2026
mdydek
requested changes
Mar 5, 2026
packages/react-native-audio-api/common/cpp/audioapi/core/analysis/AnalyserNode.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/analysis/AnalyserNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/BiquadFilterNode.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/IIRFilterNode.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioBufferSourceNode.cpp
Outdated
Show resolved
Hide resolved
...e-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferQueueSourceNodeHostObject.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RNAA-311
Closes RNAA-250
Closes RNAA-410
Part of RNAA-433
initializemethod fromStreamerNodewith passing url via ctor or factory method.AnalyserNodeIntroduced changes
CrossThreadEventSchedulerwrapper to be executed on Audio thread.HostObjectplays aShadowAudioNoderole - it stores a copy of node's state. There are some exceptions like using atomics ot triple buffer pattern.Checklist