Open
Conversation
michalsek
reviewed
Feb 17, 2026
Member
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
I think it would be good to rething start/stop methods when rotating is enabled, returning filepath on start, and only signle path on stop (with metadata) would be weird.
We could consider slightly improving the results by having:
- Only status return when start/stop is called without file output
- Single/path meta for normal file output
- Parent directory(?) for the rotating files or only status at start, list of files (or parent directory) on stop for batched files
Although not a strong opinion on the approach
mdydek
requested changes
Feb 17, 2026
...udio-api/android/src/main/cpp/audioapi/android/core/utils/ffmpegBackend/FFmpegFileWriter.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/utils/RotatingFileWriter.cpp
Show resolved
Hide resolved
...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp
Outdated
Show resolved
Hide resolved
...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp
Outdated
Show resolved
Hide resolved
...s/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/utils/RotatingFileWriter.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioFileWriter.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/core/utils/IOSFileWriter.mm
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/ios/audioapi/ios/core/IOSAudioRecorder.mm
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RNAA-384
Introduced changes
Checklist