Add assert_on_const lint#540
Merged
Merged
Conversation
wawel37
approved these changes
Jun 12, 2026
Arcticae
approved these changes
Jun 16, 2026
Arcticae
left a comment
Member
There was a problem hiding this comment.
Next time pls revert the commit + add one on top with the changes - it will make it easier to review 😄
f4c53c6 to
452bc03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #509
The implementation is identical to #388, with an additional check that fixes the panic:
cairo-lint/src/lints/assert_on_const.rs
Lines 183 to 186 in f4c53c6
Additional tests verify the proper behaviour in problematic cases (including the repro from the issue):
cairo-lint/tests/assert_on_const/mod.rs
Lines 96 to 132 in f4c53c6