update keystone to use train version#1317
Open
rajat-soda wants to merge 1 commit intosodafoundation:masterfrom
Open
update keystone to use train version#1317rajat-soda wants to merge 1 commit intosodafoundation:masterfrom
rajat-soda wants to merge 1 commit intosodafoundation:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1317 +/- ##
=======================================
Coverage 38.93% 38.93%
=======================================
Files 53 53
Lines 6966 6966
=======================================
Hits 2712 2712
Misses 3739 3739
Partials 515 515 🚀 New features to boost your workflow:
|
anvithks
reviewed
May 29, 2021
Member
anvithks
left a comment
There was a problem hiding this comment.
@rajat-soda Would it be possible to move the authchecker Docker file and code to another repository and make the changes there?
Since we are looking to make many changes going forward it would be best if we can start in an appropriate location like sodafoundation/auth or something like that.
Author
|
Yes, that is the plan. This is a WIP pr. Will be creating new repo for Soda Identity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Updates the KeyStone Version to 'train' version .
Which issue(s) this PR fixes:
Fixes # [Controller] UserManagement : Update Keystone Container to use the latest
Test Report Added?:
Test Report:
Special notes for your reviewer: