Deployment files for wordpress demo#180
Conversation
Signed-off-by: sushanthakumar <sushanth.github@gmail.com>
| @@ -0,0 +1,7 @@ | |||
| apiVersion: kahu.io/v1beta1 | |||
There was a problem hiding this comment.
Why this file is outside directly under examples? Supposed to be in a folder based on the name
There was a problem hiding this comment.
Why this file is outside directly under examples? Supposed to be in a folder based on the name
This directory contains yamls with different attributes of backup and restore yamls and sample demo folder contains some specific usecase scenarios
There was a problem hiding this comment.
I think you must create folders and sub folders for your demo. Examples folder is common to have various different demo/usecases. This file is out of place!
| @@ -0,0 +1,12 @@ | |||
| apiVersion: storage.k8s.io/v1 | |||
There was a problem hiding this comment.
Each example should have a documentation, I could not find
There was a problem hiding this comment.
yes, Doc PR will be raised referencing these files
| @@ -0,0 +1,9 @@ | |||
| apiVersion: snapshot.storage.k8s.io/v1 | |||
There was a problem hiding this comment.
This folder name is apt for the demo?!
There was a problem hiding this comment.
This folder name is apt for the demo?!
yes, openebs-zfs will be reused in different use cases for volume part. so its deployment is kept separate
There was a problem hiding this comment.
examples/sample-demos --> looks not ok.
examples//
example:
I would give something like this
examples/kahu-wordpress-demo/
OR if you want to manage kahu demos separately
examples/kahu/wordpress-demo/
Because this organization can have different projects and those may have things to add to examples
3 participants
What type of PR is this?
kind documentation
What this PR does / why we need it:
This PR adds deployment/installation files for demonstration of wordpress application
Which issue(s) this PR fixes:
This PR adds deployment/installation files for demonstration of wordpress application
Test Report Added?:
kind TESTED
Test Report:
Special notes for your reviewer: