fix: invalid spdx licenses #95
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: * Enriching a CycloneDX document with licenses will no longer generate SPDX license expressions, instead parlay will add individual license entries with the "id" field populated if the licenses are valid SPDX identifiers, or with the "name" field populated otherwise * When enriching an SPDX document with licenses, if any of the licenses aren't valid SPDX identifiers parlay will create "OtherLicense" entries in the SBOM and reference those in the "licenseConcluded" expressions
goneall
reviewed
Feb 3, 2025
Contributor
There was a problem hiding this comment.
Based on some testing, invalid concluded licenses can be generated.
Here's an example where the input SPDX JSON file had a value of "licenseConcluded": "NONE":
{
"name": "@types/node",
"SPDXID": "SPDXRef-Package-314ba809fd1a1f26",
"versionInfo": "22.13.0",
"supplier": "Organization: DefinitelyTyped",
"downloadLocation": "NONE",
"filesAnalyzed": false,
"homepage": "https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node",
"sourceInfo": "package found in: it-otf/otf-frontend/package-lock.json",
"licenseConcluded": "()",
"licenseDeclared": "MIT",
"description": "TypeScript definitions for node",
"externalRefs": [{
"referenceCategory": "PACKAGE-MANAGER",
"referenceType": "purl",
"referenceLocator": "pkg:npm/%40types/[email protected]"
}
],
"attributionTexts": ["PkgID: @types/[email protected]", "PkgType: npm"],
"primaryPackagePurpose": "LIBRARY"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.