Merged
Conversation
- Update Go version from 1.19 to 1.24.11 - Update Alpine base image from 3.18.5 to 3.21 - CI workflow update (Consul 1.8.3 → 1.22.2) - go:embed instead of go-bindata - Native go build instead of gox - Update major dependencies: - aws-sdk-go: v1.34.5 -> v1.55.8 - sentry-go: v0.14.0 -> v0.40.0 - consul/api: v1.4.0 -> v1.32.0 - consul/sdk: v0.4.0 -> v0.16.1 - golang.org/x/sys, golang.org/x/text, and others - Fix InitConsulLock to properly parse URL schemes for new consul/api - Fix test compatibility with updated dependencies - Fix Makefile sed command for macOS compatibility
This commit completes the migration from AWS SDK for Go v1 to v2, following the official AWS migration guide best practices. Key changes: - Replace session.NewSession with config.LoadDefaultConfig - Use service.NewFromConfig(cfg) for client construction - Use context-first API pattern for all AWS operations - Move to types package for enum values and structs - Use SDK v2 Waiters (ClusterRunningWaiter, ClusterTerminatedWaiter) - Use SDK v2 Paginators (s3.NewListObjectsV2Paginator) - Wrap credentials with aws.NewCredentialsCache for thread safety - Define custom interfaces for testability (replaces removed *iface) - Add *WithContext methods for context propagation - Replace deprecated ioutil with os/io packages - Use modern Go idioms (any, slices.Contains) - Replace hashicorp/errwrap with fmt.Errorf %w - Add constants for magic numbers - Use structured logging with log.Infof
Enes Aldemir (spenes)
approved these changes
Jan 20, 2026
7ee9960 to
f6d0153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.