Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
ragesh-g
marked this pull request as draft
August 4, 2026 05:22
ragesh-g
force-pushed
the
ragesh/fix-externalbrowser-race
branch
from
August 4, 2026 07:52
4e90a60 to
c8accc4
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
ragesh-g
marked this pull request as ready for review
August 4, 2026 07:55
ragesh-g
force-pushed
the
ragesh/fix-externalbrowser-race
branch
from
August 4, 2026 10:17
c8accc4 to
b770376
Compare
|
@ragesh-g has anyone helped you on the snowflake side get this change in? |
Author
@hope-wat I was told it was being discussed internally #1829 (comment) |
Collaborator
|
Ok, I got a green light on this! Can you solve conflicts? |
Serve the external-browser callback with http.Server so each connection is handled concurrently. An idle connection, such as a browser TCP preconnect, or a partially sent request can no longer block the connection carrying the callback. The Origin, preflight, and POST handling from SNOW-4109574 runs unchanged inside the handler. Fixes snowflakedb#1829. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ragesh-g
force-pushed
the
ragesh/fix-externalbrowser-race
branch
from
October 5, 2026 07:29
f7ae3be to
8fe6d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SNOW-3887337 Fix external-browser authentication hanging when an idle connection reaches the callback listener before the real browser redirect.
Fixes #1829. Originally reported in dbt-labs/dbt-core#14565.
Chrome TCP preconnect can open multiple sockets for one redirect: one carries the
GET /?token=...callback while a spare connection remains idle. The driver previously calledAccept()only once and blocked reading that connection, so authentication timed out when the idle socket was accepted first.This change serves the callback with
http.Server, allowing connections to be handled concurrently until a valid token arrives, the caller cancels, or authentication times out.Checklist