Fix FST module build failure on older glibc due to missing BSD TCP/UDP header names#38
Open
ssam18 wants to merge 1 commit into
Open
Fix FST module build failure on older glibc due to missing BSD TCP/UDP header names#38ssam18 wants to merge 1 commit into
ssam18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux systems with older glibc or musl libc, the BSD-style TCP/UDP struct field names (th_off, th_flags, th_sport, uh_ulen, etc.) are only available when __FAVOR_BSD is defined before including the netinet headers. Without it, the FST module fails to compile with errors about missing members like th_off and undeclared TH_SYN/TH_ACK/TH_FIN constants. Defining __FAVOR_BSD on Linux in netinet_compat.h fixes the build across all glibc versions and is a no-op on modern glibc where the anonymous union already exposes both naming conventions. Fixes #25