Skip to content

remove unused environment variable from sobelow scanner #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptzianos merged 1 commit into from
Nov 18, 2025
Merged

remove unused environment variable from sobelow scanner #1123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions components/scanners/sobelow/internal/transformer/transformer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import (
componentlogger "github.com/smithy-security/smithy/sdk/logger"
)

const TargetTypeRepository TargetType = "repository"

type (
// SobelowTransformerOption allows customising the transformer.
SobelowTransformerOption func(g *sobelowTransformer) error
Expand All @@ -27,7 +25,6 @@ type (
TargetType string

sobelowTransformer struct {
targetType TargetType
clock clockwork.Clock
resultsDirPath string
workspacePath string
Expand All @@ -49,17 +46,6 @@ func SobelowTransformerWithClock(clock clockwork.Clock) SobelowTransformerOption
}
}

// SobelowTransformerWithTarget allows customising the underlying target type.
func SobelowTransformerWithTarget(target TargetType) SobelowTransformerOption {
return func(g *sobelowTransformer) error {
if target == "" {
return errors.Errorf("invalid empty target")
}
g.targetType = target
return nil
}
}

// SobelowResultsDirPath allows customising the results directory path
func SobelowResultsDirPath(path string) SobelowTransformerOption {
return func(g *sobelowTransformer) error {
Expand All @@ -82,15 +68,6 @@ func New(opts ...SobelowTransformerOption) (*sobelowTransformer, error) {
return nil, err
}

target, err := env.GetOrDefault(
"SOBELOW_TARGET_TYPE",
TargetTypeRepository.String(),
env.WithDefaultOnError(true),
)
if err != nil {
return nil, err
}

workspacePath, err := env.GetOrDefault(
"WORKSPACE_PATH",
"",
Expand All @@ -101,7 +78,6 @@ func New(opts ...SobelowTransformerOption) (*sobelowTransformer, error) {
}

t := sobelowTransformer{
targetType: TargetType(target),
clock: clockwork.NewRealClock(),
resultsDirPath: resultsDirPath,
workspacePath: workspacePath,
Expand All @@ -116,8 +92,6 @@ func New(opts ...SobelowTransformerOption) (*sobelowTransformer, error) {
switch {
case t.resultsDirPath == "":
return nil, errors.New("invalid empty results directory path")
case t.targetType == "":
return nil, errors.New("invalid empty target type")
}

return &t, nil
Expand Down
Loading