feat(fact-smoke-003): add buildBucketUrl with optional key param - #1
Open
gurdasnijor wants to merge 2 commits into
Open
feat(fact-smoke-003): add buildBucketUrl with optional key param#1gurdasnijor wants to merge 2 commits into
gurdasnijor wants to merge 2 commits into
Conversation
added 2 commits
May 1, 2026 00:31
Adds a small helper that constructs an R2-style bucket URL where the object key is optional, exercised by node:test cases. Wires up a CI workflow so the suite runs on PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
FACT-SMOKE-003 — smoke test post-fix, verifying optional bucket URL.
Summary
src/bucket-url.jswithbuildBucketUrl({ bucket, key, base }). Thekeyargument is optional — when omitted, the URL points at the bucket root.test/bucket-url.test.jswith fournode:testcases covering: bucket-only URL, bucket+key URL, custom base, and the missing-bucket error path.npm teston PRs.Proof of work
```
$ npm test
tests 4
pass 4
fail 0
```
Trace zip uploaded to the factory artifact URL.