Skip to content

Conversation

@tashian
Copy link
Contributor

@tashian tashian commented Jan 15, 2026

No description provided.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jan 15, 2026
@hslatman hslatman changed the title [CON-308] Update --kms flag help Update --kms flag help Jan 15, 2026
@hslatman
Copy link
Member

Towards: CON-308

@hslatman hslatman added this to the v0.29.1 milestone Jan 15, 2026
<uri> is formatted as **kmstype:[key=value;...]?[key=value&...]**. The **;**-separated
parameters identify the KMS, and **&**-separated parameters contain credentials.
: Supported KMS types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want capi, mackms, softkms and sshagentkms here too, to make the list from https://github.com/smallstep/step-kms-plugin/blob/main/main.go#L19-L29 complete? They're not all as well-known as the ones you already listed, but capi can be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with just having the most common options shown, and if people dig into step-kms-plugin for the others. I guess I'm sensitive to the length of the help text.

tashian and others added 2 commits January 15, 2026 09:55
Co-authored-by: Herman Slatman <[email protected]>
Co-authored-by: Herman Slatman <[email protected]>
@hslatman hslatman changed the title Update --kms flag help Update --kms flag help Jan 15, 2026
@tashian tashian enabled auto-merge January 15, 2026 17:16
@tashian tashian merged commit b628162 into master Jan 15, 2026
16 checks passed
@tashian tashian deleted the carl/con-308 branch January 15, 2026 17:31
@hslatman
Copy link
Member

Btw, I changed the title and moved the issue number for tracking to a comment. Generally it's sufficient to put it in the git commit message, and it will be tracked. At least for the internal projects. No need to litter the title with non-functional metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants