-
Notifications
You must be signed in to change notification settings - Fork 289
Update --kms flag help
#1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update --kms flag help
#1550
Conversation
|
Towards: CON-308 |
| <uri> is formatted as **kmstype:[key=value;...]?[key=value&...]**. The **;**-separated | ||
| parameters identify the KMS, and **&**-separated parameters contain credentials. | ||
| : Supported KMS types: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want capi, mackms, softkms and sshagentkms here too, to make the list from https://github.com/smallstep/step-kms-plugin/blob/main/main.go#L19-L29 complete? They're not all as well-known as the ones you already listed, but capi can be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with just having the most common options shown, and if people dig into step-kms-plugin for the others. I guess I'm sensitive to the length of the help text.
Co-authored-by: Herman Slatman <[email protected]>
Co-authored-by: Herman Slatman <[email protected]>
|
Btw, I changed the title and moved the issue number for tracking to a comment. Generally it's sufficient to put it in the git commit message, and it will be tracked. At least for the internal projects. No need to litter the title with non-functional metadata. |
No description provided.