Fix EU build, fix its audio samples, fix its menu texts - #607
Open
maxgerhardt wants to merge 4 commits into
Open
Fix EU build, fix its audio samples, fix its menu texts#607maxgerhardt wants to merge 4 commits into
maxgerhardt wants to merge 4 commits into
Conversation
VERSION_ASFLAGS was overwritten instead of appended, so sequences assembled with US opcodes while the EU engine decoded them, corrupting note allocation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
gCurrAudioFrameDmaCount was never reset in the PC port, overflowing gCurrAudioFrameDmaIoMesgBufs[] after a second of playback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
textSaveExitGame rows were 26 bytes; the German 'SPEICHERN & SPIEL VERLASSEN' needs 28 (27 chars + terminator), so it was truncated unterminated and bled into the next array's English text. Size the rows to 28. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the build failure described in #535 by adding
#include "heap.h".Additionally fixes the problem that audio cuts out after only a second in the title screen and ingame. The audio samples were always built for the US variant, a Makefile line overwrote previously existing options.
Additionally fixes a bug in the menu rendering that shows up after a level was finished. The german version's text was longer than 26 characters so it got weirdly overwritten. Increase it to 28.
Before:
After:
So, this gets this game from unbuildable in the current version to nicely playable.