Skip to content

Press start to play fix for ex - #382

Closed
tailscreatesstuff32 wants to merge 4 commits into
sm64pc:nightlyfrom
tailscreatesstuff32:press-start-to-play-fix-for-ex
Closed

Press start to play fix for ex#382
tailscreatesstuff32 wants to merge 4 commits into
sm64pc:nightlyfrom
tailscreatesstuff32:press-start-to-play-fix-for-ex

Conversation

@tailscreatesstuff32

@tailscreatesstuff32 tailscreatesstuff32 commented Jul 25, 2020

Copy link
Copy Markdown

I fixed the press start to play issue. Locate in level_select_menu.c

fixed missing press start to play sound and hello when demo starts from begining.
fixed missing press start to play sound and hello when demo starts from begining.
fixed missing press start to play sound and hello when demo starts from begining.
fixed missing press start to play sound and hello when demo starts from begining.
@fgsfdsfgs

Copy link
Copy Markdown
Collaborator

You seem to have tried to PR a nightly-based branch into master. Please retarget to nightly.

@tailscreatesstuff32
tailscreatesstuff32 changed the base branch from master to nightly July 26, 2020 02:47
@rawr51919

Copy link
Copy Markdown
Contributor

@fgsfdsfgs Target's changed to the proper target. Try another look now

@fgsfdsfgs

Copy link
Copy Markdown
Collaborator

That diff nukes and replaces the entire file. Maybe different line endings? I wouldn't advise using Github's file upload feature for PRs.

@rawr51919

Copy link
Copy Markdown
Contributor

The one who made this PR isn't very well versed with PRs in general so I may try to optimize this PR a bit later. Hopefully it'll help

@rawr51919

rawr51919 commented Feb 12, 2021

Copy link
Copy Markdown
Contributor

PR #455 supersedes this PR

@fgsfdsfgs

Copy link
Copy Markdown
Collaborator

This still nukes and replaces the entire file, so closing.

@fgsfdsfgs fgsfdsfgs closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants