fix: respect percentDisplayMode in /quota command#117
Open
XDayonline wants to merge 1 commit into
Open
Conversation
The /quota command hardcoded '% left' regardless of the percentDisplayMode config setting. Now uses formatDisplayedPercentLabel() to respect the configured mode, matching sidebar and compact status behavior. Fixes slkiser#116
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/quotaslash command hardcodes% leftregardless of thepercentDisplayModeconfig setting. This makes it inconsistent with the sidebar and compact status, which correctly respect the setting.Problem
percentDisplayMode: "used"in configXX% used(correct)/quotashowsXX% left(wrong — ignores config)Root Cause
src/lib/quota-command-format.ts:75hardcodes:While sidebar/compact use
formatDisplayedPercentLabel()which respectspercentDisplayMode.Fix
formatDisplayedPercentLabelinquota-command-format.ts% leftwithformatDisplayedPercentLabel(row.percentRemaining, params.percentDisplayMode)percentDisplayModefromruntime.configthroughhandleQuotaSlashCommandTesting
tests/plugin.quota-command.test.tspassCloses #116