Fix 404 contact link in the German, Korean and Simplified-Chinese GenStudio post - #34
Open
eastagiletracker wants to merge 1 commit into
Open
Conversation
The in-body contact CTA in the German, Korean and Simplified-Chinese copies of blog/secure-and-private-gpt4-chat-via-skydeck-genstudio still points at the pre-migration URL /contact/, which the Astro site does not build (https://www.skydeck.ai/contact/ returns 404 today). The other nine locales already link /{lang}/about/skydeck-contact-us; point these three at their own locale's contact page too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes fixing the in-body contact link in the German, Korean and Simplified-Chinese copies of the GenStudio blog post, which currently 404s on the deployed site. We include this PR work along with a full history of your repo at https://eastagiletracker.com/projects/161. You can sign in with your GitHub ID to claim ownership of the project.
The in-body contact call-to-action in the German, Korean and Simplified-Chinese copies of
blog/secure-and-private-gpt4-chat-via-skydeck-genstudiostill points at the pre-migration URL/contact/. The Astro site does not build that path, so those three links are a dead end for readers: fetching/contact/on the deployed site returns 404 today, while/de/about/skydeck-contact-us,/ko/about/skydeck-contact-usand/zh-cn/about/skydeck-contact-usall return 200. The nine other locales of the same post already link/{lang}/about/skydeck-contact-us— de, ko and zh-cn were simply left behind on the old root path when the content moved intosite/src/content-legacy/.This changes exactly three
hrefvalues, one per locale file, to the locale's own contact page — the same target its nine siblings use. Nothing else in the content or the layout is touched.How I checked it: I crawled every root-relative
href/srcin a freshnpm run buildofsite/against the files the build actually emits. Before the change,/contact/was referenced from three built pages with no corresponding output; after it, that target is gone and the build is unchanged at 624 pages. The repo-artifact contracts intests/marketing(C12 and C12b) still pass. One other pre-migration root-relative link survives in the de and ko copies of a neighbouring post, but the other ten locales carry the same target in its absolute form, so picking a replacement is a content decision I left to you — happy to follow up if you want it fixed the same way.How this was managed
I tracked this fix on a live board, imported from this repository's own pull requests and labels (33 stories, 4 labels), so the trail is public rather than buried in a local checkout. The story for this change is Contact CTA 404s in the de/ko/zh-cn copies of the GenStudio blog post, moved through started and finished as the work landed, and the whole board is at eastagiletracker.com/projects/161.
If you'd rather not receive contributions like this, reply
no-more-prson this pull request and we won't open any further ones on your repositories.Lawrence W. Sinclair
CEO / East Agile
linkedin.com/in/lwsinclair/
eastagile.com