Merged
Conversation
The getRemotePK function called appnet.WrapConn which uses ConvertAddr, but ConvertAddr only handles dmsg.Addr and routing.Addr types. Connections from the app framework already use appnet.Addr, hitting the default case and returning "addr type is unknown", causing all whitelist connections to be rejected. Fix by asserting appnet.Addr directly first.
Whitelist-protected skysocks servers are not public and should not register in service discovery, matching the existing passcode behavior.
…tion Vendor skycoin commit 184fef102ebb365b646567f4cd4f8eee5fbaeceb. Fix VPN server getRemotePK having the same appnet.Addr type assertion bug as skysocks - WrapConn/ConvertAddr doesn't handle appnet.Addr, causing all whitelist connections to be rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.