Consolidate null-provider bookkeeping and drop redundant deserialize() overrides in SettableAnyProperty - #2
Draft
java-dependency-upgrade-fixer[bot] wants to merge 1 commit into
Conversation
…) overrides in SettableAnyProperty
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounded cleanup pass over the single production file already changed by the mirrored PR (
Apply default null handling to @JsonAnySetter), scoped strictly insideSettableAnyProperty.java.Changes
(_valueDeserializer == _nullProvider) ? deser : _nullProvider(deciding whether to keep tracking the value deserializer as the null provider, or preserve an explicitly-configured null provider) was duplicated identically acrossMethodAnyProperty,MapFieldAnyProperty,JsonNodeFieldAnyProperty, andMapParameterAnyProperty'swithValueDeserializer()overrides. Extracted into one protected helper_nullProviderFor(ValueDeserializer<Object>)on the base class.JsonNodeFieldAnyProperty.deserialize()andJsonNodeParameterAnyProperty.deserialize()duplicated the base class'sdeserialize()logic. Both subclasses always construct with anullTypeDeserializer, so once the PR added the null-provider check to the base method, the base method's behavior for these subclasses is provably identical to the override body (confirmed via bytecode inspection thatJsonParser.hasToken(t)is exactlycurrentToken() == t). Removed the now-dead-weight overrides.Behavior preservation
SettableAnyProperty/PropertyValueBuffer) passes identically before and after../mvnw clean verifypasses: 6188 tests, 0 failures, 0 errors, 1 pre-existing unrelated skip.Limitations
Generated by JAIPilot Cloud for #1 from Anthropic session
sesn_01TQjNkpqQAVX9eQTgVJwyL7.