test: Check that the graph contains expected nodes#17
Open
wentasah wants to merge 1 commit intoskoudmar:graphsfrom
Open
test: Check that the graph contains expected nodes#17wentasah wants to merge 1 commit intoskoudmar:graphsfrom
wentasah wants to merge 1 commit intoskoudmar:graphsfrom
Conversation
Currently, this fails for rolling because trace is empty. It needs to be investigated why.
Contributor
|
OK I found the issue, not sure where it originated but: The edge IDs (in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merged the
mainbranch tographsso that we can add tests for the graphing functionality. In this PR, I added the first simple test for theextractsubcommand. Currently, this test fails (and has always failed) for rolling because the trace is empty. It needs to be investigated why (I can do it later).However, the
add_two_ints servicetest, which passes on the main branch fails on thegraphsbranch. So this is either caused by my incorrect resolution of a conflict betweenmainandgraphsbranches, or it is caused by the "graphing" changes in this branch. @Pavel-Sedlacek can you look at that?For completeness, the r2ta output is: