Skip to content

Conversation

@woo943
Copy link
Contributor

@woo943 woo943 commented Jan 22, 2026

Description

  • course edit 모달의 디자인을 변경했습니다.
  • weeks 드롭다운폼의 문구를 변경했습니다.
  • weeks의 스키마가 number로 되어있어서 OptionSelect.tsx에서 option을 {label, value}로 받을 수 있도록 변경했습니다.
  • Contact 칸의 이메일과 전화번호를 디자인과 동일하게 여러 칸으로 나눴습니다.
  • 이메일과 전화번호를 다시 하나로 저장할 수 있는 로직을 추가했습니다.
image image

Additional context

close TAS-2428


Before submitting the PR, please make sure you do the following

@woo943 woo943 self-assigned this Jan 22, 2026
@skkuding-bot
Copy link

skkuding-bot bot commented Jan 22, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 23d6a797faa1da133315526c5a00c3b27459e79d
Health Status: Healthy

Open Preview | View in Argo CD

Copy link
Contributor

@seoeun9 seoeun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI 너무 깔끔하게 잘 만들어주셨네요~! 고생 많으셨습니다ㅎㅎ 👍👍
문제가 하나 있다면 week, 전화번호 등은 수정사항 반영이 안 되는 거 같은데 이건 이전부터 그랬어서, 저도 문제를 찾아보고 있습니다..! 최대한 빨리 리뷰 완성할게요

@notion-task-integration
Copy link

notion-task-integration bot commented Jan 24, 2026

@skkuding-bot
Copy link

skkuding-bot bot commented Jan 24, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 47e8a31a568cafd2b2ea64acdd1adca931e72ecf
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot
Copy link

skkuding-bot bot commented Feb 2, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 73a4f747cfd0b066ad8d8b48a658fea8365ca2c8
Health Status: Healthy

Open Preview | View in Argo CD

@woo943 woo943 enabled auto-merge February 3, 2026 05:25
Copy link
Contributor

@seoeun9 seoeun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ LGTM!!
useForm 관련 문제는 따로 태스크를 파보아요

@woo943 woo943 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 68e237f Feb 5, 2026
11 checks passed
@woo943 woo943 deleted the t2428-change-course-edit-design branch February 5, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants