Declare Android host triples in skip-linux artifactbundle supportedTriples - #266
Open
hpr wants to merge 2 commits into
Open
Declare Android host triples in skip-linux artifactbundle supportedTriples#266hpr wants to merge 2 commits into
hpr wants to merge 2 commits into
Conversation
…iples
The static-MUSL skip binary runs fine on Android (bionic) hosts such as
Termux, but the generated info.json only listed *-unknown-linux-gnu, so
SwiftPM rejects the binary target there ('Tool skip is not supported on
the target platform'). Add the Android host triples (generic + API 24,
both arches) to each variant's supportedTriples.
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @hpr on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release-built
skip-linux.zipartifactbundle declares only*-unknown-linux-gnuin each variant'ssupportedTriples(generated here inbuild_linux_plugin.sh). The static-MUSLskipbinary itself runs fine on Android (bionic) hosts — verified on-device (aarch64 Termux, Swift 6.3.2 Android toolchain) — but SwiftPM rejects the binary target there with "Tool 'skip' is not supported on the target platform" because the host triple (aarch64-unknown-linux-android24) isn't listed.Together with skiptools/skip#725 (which makes the manifest select the Linux binary target for
os(Android)hosts), this lets Android hosts use the prebuilt transpiler instead of building skipstone + SwiftSyntax from source — a host build that spikes 5–8 GB RSS per swift-frontend process and OOM-kills typical Android devices.Change
Add
<arch>-unknown-linux-androidand<arch>-unknown-linux-android24tosupportedTriplesfor each built arch. No binary changes; the triples are only host-platform declarations for SwiftPM's artifact selection. (API 24 matches the swift.org Android toolchain's host triple; the generic-androidtriple covers other Android environments.)Testing
Validated the generated
info.jsonsyntax by simulating the VARIANTS loop; verified end-to-end earlier by repacking the published 1.9.5skip-linux.zipwith these triples added — SwiftPM on-device then accepts the binary target and skipstone/SwiftSyntax leave the dependency graph entirely.