Fix Font.custom(_:size:relativeTo:) sizing on Android - #511
Open
gurmeherchawla wants to merge 1 commit into
Open
Fix Font.custom(_:size:relativeTo:) sizing on Android#511gurmeherchawla wants to merge 1 commit into
gurmeherchawla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Font.custom(_:size:relativeTo:)was computing the Android font size incorrectly. The previous implementation added the base text style's system font size on top of the caller-suppliedsize:This produced fonts that were too large (e.g. a
.caption-relative custom font of 14pt would actually render at ~26sp), and therelativeTostyle was being used as an additive offset rather than just a scaling reference.Fix
Use
sizedirectly inspunits and drop the additive offset:sizeis the absolute point size at the default Dynamic Type level per the SwiftUI docs. Usingspensures it scales proportionally with Android's font size accessibility setting — the closest equivalent to iOS Dynamic Type scaling.This also aligns the behavior of
Font.custom(_:size:relativeTo:)with the already-correctFont.custom(_:size:)implementation.Testing
Personally tested on a real Android device with multiple Dynamic Type levels. Custom fonts now render at the expected size and scale correctly with accessibility font size changes.