Compile on Linux - #10
Open
piercifani wants to merge 2 commits into
Open
Conversation
The Linux host pass of `skip export` compiles this package natively, where the non-SKIP branch's `import Security` fails (Security is Darwin-only). Guard the Darwin implementation behind canImport(Security) with a throwing stub fallback, nested inside the existing !SKIP branches so the transpiled Kotlin output is unchanged (verified byte-identical vs 0.3.2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
marcprux
requested changes
Jul 17, 2026
Member
There was a problem hiding this comment.
Great contribution!
Could you also turn on the Linux CI build in .github/workflows/ci.yml so we can get ongoing validation that it builds and tests on Linux (e.g., see https://github.com/skiptools/skip-android-bridge/pull/31/changes#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR18)?
Adds ubuntu-24.04 alongside the default macos-15-intel runner, matching skip-android-bridge, so the Linux host build is validated on every push. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Thanks for adding the Linux CI. I think it is failing because you need to also add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux host pass of
skip exportcompiles this package natively, where the non-SKIP branch'simport Securityfails (Security is Darwin-only).Guard the Darwin implementation behind
canImport(Security)with a throwing stub fallback, nested inside the existing!SKIPbranches so the transpiled Kotlin output is unchanged.Skip Pull Request Checklist:
swift testIt helped me understand where the issue was coming from and how to best attack it.