Reset VisualComplete99 when the page repaints backward#2537
Merged
Conversation
When the visual progress curve dips back below a threshold — a real browser behaviour where the page momentarily un-completes and repaints — the crossed milestones are meant to be invalidated and re-found at the later time the page climbs back up. Two copy-paste typos reset VisualComplete95 twice instead of ever resetting VisualComplete99, so 99% kept a stale early timestamp. On a page that reaches 100%, repaints backward, then recovers, VisualComplete99 could report a time earlier than VisualComplete95 — 99% complete before 95%, which cannot happen — and is optimistically wrong for every dashboard and report that reads it. Adds the first unit test for this file. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I9038fe3147788dddafc0805cf661fc39b0c2c7fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the visual progress curve dips back below a threshold — a real browser behaviour where the page momentarily un-completes and repaints — the crossed milestones are meant to be invalidated and re-found at the later time the page climbs back up. Two copy-paste typos reset VisualComplete95 twice instead of ever resetting VisualComplete99, so 99% kept a stale early timestamp. On a page that reaches 100%, repaints backward, then recovers, VisualComplete99 could report a time earlier than VisualComplete95 — 99% complete before 95%, which cannot happen — and is optimistically wrong for every dashboard and report that reads it. Adds the first unit test for this file.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I9038fe3147788dddafc0805cf661fc39b0c2c7fc