Remove dead code from visual metrics#2534
Merged
Merged
Conversation
The repo carried two visual metrics scripts, but only the portable one is invoked or shipped in the npm package — the old ImageMagick-based visualmetrics.py has been unreachable for years and its 2 600 lines kept showing up in searches and audits as if they were live code. The portable script itself had accumulated leftovers from that conversion: an advertised --render option that was never implemented, three functions nothing calls, unused locals and an ImageMagick-output regex in code that no longer shells out. Also fixes the regex escape that made Python 3.12+ print a SyntaxWarning on every single run. No behaviour change: the unit test suite and a full end-to-end run on a recorded video produce identical output before and after. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I3688b38c986644f4dacc7def8bc61b50e4cf84bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo carried two visual metrics scripts, but only the portable one is invoked or shipped in the npm package — the old ImageMagick-based visualmetrics.py has been unreachable for years and its 2 600 lines kept showing up in searches and audits as if they were live code. The portable script itself had accumulated leftovers from that conversion: an advertised --render option that was never implemented, three functions nothing calls, unused locals and an ImageMagick-output regex in code that no longer shells out. Also fixes the regex escape that made Python 3.12+ print a SyntaxWarning on every single run.
No behaviour change: the unit test suite and a full end-to-end run on a recorded video produce identical output before and after.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I3688b38c986644f4dacc7def8bc61b50e4cf84bb