Add a visual instability heatmap to the frame diffs#2533
Merged
Conversation
Per-frame diffs answer "what changed in this frame", but the question that cost us days on a recent Last Visual Change hunt was "which parts of the page keep changing" — invisible re-rasterization noise looks exactly like real churn until you see it accumulated. The diff loop already walks every adjacent frame pair, so it now also counts how many times each pixel changed and writes one instability.png: the final frame ghosted, changed pixels tinted amber (changed once) to deep red (changed ten or more times). Stable pages read as flat amber; noise reads as red speckle in the shape of the text; a restless ad slot reads as a solid red block. The color scale is fixed rather than normalized per run so two runs' heatmaps compare side by side. A Frame Instability summary in the JSON (share of pixels changed once / repeatedly, max changes) lets dashboards track restlessness over time. Everything rides the existing videoParams.filmstripDiff flag. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I7022eb7f85d235adb8fff95838296f2107c2a520
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-frame diffs answer "what changed in this frame", but the question that cost us days on a recent Last Visual Change hunt was "which parts of the page keep changing" — invisible re-rasterization noise looks exactly like real churn until you see it accumulated. The diff loop already walks every adjacent frame pair, so it now also counts how many times each pixel changed and writes one instability.png: the final frame ghosted, changed pixels tinted amber (changed once) to deep red (changed ten or more times). Stable pages read as flat amber; noise reads as red speckle in the shape of the text; a restless ad slot reads as a solid red block. The color scale is fixed rather than normalized per run so two runs' heatmaps compare side by side.
A Frame Instability summary in the JSON (share of pixels changed once / repeatedly, max changes) lets dashboards track restlessness over time. Everything rides the existing videoParams.filmstripDiff flag.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I7022eb7f85d235adb8fff95838296f2107c2a520