Test the visual metrics calculations in CI#2532
Merged
Merged
Conversation
The Speed Index, visual progress and visual change math in visualmetrics-portable.py had no test coverage at all: the existing test file imported the mozilla-central Python packaging of the old script, which does not exist in this repo, so it could never run. Any change to the metric calculations would silently shift metrics for every user. The test data frames already in the repo now feed the shipped portable script directly, with the computed values pinned: First and Last Visual Change, Speed Index, the full visual progress curve, and the contentful/perceptual variants (skipped when OpenCV or pyssim is missing). A test for the upcoming frame-diff feature skips with a reason until that branch lands, so the two merge in either order. A new dedicated GitHub Action runs the suite; it finishes in under a second. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I625e90cf2b0edea9786ddf1d46bf7a69b240bc13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Speed Index, visual progress and visual change math in visualmetrics-portable.py had no test coverage at all: the existing test file imported the mozilla-central Python packaging of the old script, which does not exist in this repo, so it could never run. Any change to the metric calculations would silently shift metrics for every user.
The test data frames already in the repo now feed the shipped portable script directly, with the computed values pinned: First and Last Visual Change, Speed Index, the full visual progress curve, and the contentful/perceptual variants (skipped when OpenCV or pyssim is missing). A test for the upcoming frame-diff feature skips with a reason until that branch lands, so the two merge in either order. A new dedicated GitHub Action runs the suite; it finishes in under a second.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I625e90cf2b0edea9786ddf1d46bf7a69b240bc13