Precompute filmstrip frame diffs in visual metrics#2531
Merged
Conversation
Report UIs cannot read frame pixels when a result is opened from file:// — the canvas is tainted and fetch is blocked — so an exact "what changed in this frame" view was impossible exactly where people debug local results. Visual metrics already walks every adjacent frame pair with Pillow in hand, so the diff belongs here. With videoParams.filmstripDiff, write diff_<ms>.png next to each filmstrip frame — the frame dimmed with every changed pixel painted red, the same per-pixel threshold report UIs use at runtime so both paths show the same picture — and report the counts as a Frame Diffs metric. Off by default: it is one extra image per frame per run, stored wherever results are stored. PNG on purpose — mostly white plus sparse red compresses far below the frame JPEGs. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I469edacc66efa9386d20867d9d8cf08953337115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report UIs cannot read frame pixels when a result is opened from file:// — the canvas is tainted and fetch is blocked — so an exact "what changed in this frame" view was impossible exactly where people debug local results. Visual metrics already walks every adjacent frame pair with Pillow in hand, so the diff belongs here.
With videoParams.filmstripDiff, write diff_.png next to each filmstrip frame — the frame dimmed with every changed pixel painted red, the same per-pixel threshold report UIs use at runtime so both paths show the same picture — and report the counts as a Frame Diffs metric. Off by default: it is one extra image per frame per run, stored wherever results are stored. PNG on purpose — mostly white plus sparse red compresses far below the frame JPEGs.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I469edacc66efa9386d20867d9d8cf08953337115