Add advanced rejudge scheduling by Jankwi · Pull Request #754 · sio2project/oioioi

Jankwi · 2026-05-27T14:34:28Z

This commit adds a scheduling option, which allows the user to specify how submission jobs will be evaluated in the rejudge queue, with the following options:

Instant - submissions are evaluated ASAP.
Delayed - submissions jobs are switched from queued to waiting, evenly over 10 minutes.
Slow - same as above, but over 1 hour.
Custom - The user can specify that X new submissions will be switched from queued to waiting every Y seconds.

With the info button pressed, the screen looks like this:

Note: This is a clean version of this old draft PR: #724

Closes: #672

(Still with hardcoded values)

Copilot

Pull request overview

Adds an “evaluation scheduling” option to the rejudge flow so admins can spread rejudge jobs over time (instant / delayed / slow / custom cadence), leveraging Celery countdown scheduling.

Changes:

Extend judge() plumbing (contest + problem controllers) to accept an optional delay and pass it to the eval manager as countdown.
Add scheduling parameter parsing and apply per-submission delays when enqueueing rejudge jobs.
Add UI controls and tests for the new scheduling options.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`oioioi/problems/controllers.py`	Adds `delay` parameter and forwards it as Celery `countdown` when scheduling evaluation.
`oioioi/contests/controllers.py`	Extends contest-controller `judge()` to forward `delay` to the problem controller.
`oioioi/contests/views.py`	Implements scheduling option parsing and applies computed delays during rejudge enqueueing.
`oioioi/contests/templates/contests/confirm_rejudge.html`	Adds scheduling selector UI (instant/delayed/slow/custom) and custom-parameter inputs.
`oioioi/contests/tests/tests.py`	Adds tests validating that delays are passed to `judge()` according to selected scheduling.
`oioioi/default_settings.py`	Introduces default settings for delayed/slow durations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Previously, if 0 submission were selected with a custom rejudge ootion, the program tried to divide the time by 0, to spread them out evenly. This commit adds necessary guards, so that for 0 selected submissions these calculations are not completed. Selecting 0 submissions is not an error, but it doesn't result in anything besides a message.

sylwia-sapkowska

Looks ok to me.

sonarqubecloud · 2026-06-10T13:06:35Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Jankwi · 2026-06-10T13:07:45Z

@twalen I have moved CSS from the html file, to a separate static file as requested. This PR should be ready for merge now.

malevitzch

I have a few problems with the style, otherwise it looks solid

malevitzch · 2026-06-21T09:33:54Z

+                });
+            }
+
+            // Initialize on page load


I would remove this comment

malevitzch · 2026-06-21T09:35:08Z

+    border-bottom-right-radius: 0.375rem;
+}
+
+/* Active State Style */


This comment is obsolete and the code already passes that infromation in the css class name "btn-check:chceked"

malevitzch · 2026-06-21T09:37:40Z

 FORUM_POST_MAX_LENGTH = 20000
 FORUM_REACTIONS_TO_DISPLAY = 10

+# REJUDGE EVALUATION SCHEDULING VARIABLES


I don't think this comment should be in all caps, other comments in the same file use regular case

malevitzch · 2026-06-21T09:42:11Z

        pass

-    def judge(self, submission, extra_args=None, is_rejudge=False):
+    def judge(self, submission, extra_args=None, is_rejudge=False, delay: int | float = 0):


The single type annotation stands out here, I understand that submission can't be typed right now, but extra_args could be "dict[str, Any] | None" and is_rejudge could just be "bool" if you wish to use type annotations

malevitzch · 2026-06-21T09:43:32Z


-    def judge(self, submission, extra_args=None, is_rejudge=False):
-        submission.problem_instance.problem.controller.judge(submission, extra_args, is_rejudge)
+    def judge(self, submission, extra_args=None, is_rejudge=False, delay: int | float = 0):


I don't like the typing here, same as in oioioi/problems/controllers.py

malevitzch · 2026-06-21T09:44:46Z

+                const delayStepInput = document.getElementById('custom_delay_step');
+
+                if (batchSizeInput && delayStepInput) {
+                    // Check if custom is already selected on page load


And this one, those comments are made obsolete by reading the code even without deeper javascript knowledge

malevitzch · 2026-06-21T09:46:41Z

+                    const batchSizeInput = document.getElementById('custom_batch_size');
+                    const delayStepInput = document.getElementById('custom_delay_step');
+
+                    if (this.value === 'custom') {


Feels like you are doing CSS's job with javascript here, but I might be wrong

Jankwi added 7 commits May 27, 2026 13:42

Add delay option to judge job

89aa7d2

Add delay poc

f6d579f

Add more scheduling options

7957782

(Still with hardcoded values)

Add info button & constants

7352350

Add tests

801ab29

Apply ruff fixes

0602cf5

Move constants to settings

5fd381d

Copilot AI review requested due to automatic review settings May 27, 2026 14:34

Jankwi requested a review from MasloMaslane as a code owner May 27, 2026 14:34

Copilot started reviewing on behalf of Jankwi May 27, 2026 14:34 View session

Jankwi mentioned this pull request May 27, 2026

Add evaluation scheduling option to rejudging #724

Closed

Copilot AI reviewed May 27, 2026

View reviewed changes

sylwia-sapkowska self-requested a review May 27, 2026 16:37

Jankwi and others added 4 commits May 27, 2026 21:56

Apply suggestions from code review

96233c4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix code review changes

b578676

Fix html form

21b33b0

sylwia-sapkowska previously approved these changes Jun 2, 2026

View reviewed changes

Move CSS to static

a2aaf49

Jankwi dismissed sylwia-sapkowska’s stale review via a2aaf49 June 10, 2026 13:05

malevitzch reviewed Jun 21, 2026

View reviewed changes

Uh oh!

Conversation

Jankwi commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sylwia-sapkowska left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 10, 2026

Quality Gate passed

Uh oh!

Jankwi commented Jun 10, 2026

Uh oh!

malevitzch left a comment

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

malevitzch Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jankwi commented May 27, 2026 •

edited

Loading