enable self healing after offset out of range kafka error#18
Merged
Conversation
igrowbeards
requested review from
LiruMouse,
ctcline-simplifi,
joshuawscott and
nathanmonteleone
as code owners
June 15, 2026 16:38
joshuawscott
approved these changes
Jun 17, 2026
joshuawscott
approved these changes
Jun 17, 2026
ashley-graham
approved these changes
Jun 18, 2026
ashley-graham
left a comment
ashley-graham
left a comment
There was a problem hiding this comment.
Thank you for showing what you're working on so that I can learn from it in comparison to my chaos testing on apps using kafka_ex!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed during the kafka upgrade a few weeks ago that some of our applications did not come back up cleanly and required a manual restart to start the consumers consuming again. I believe i've traced the issue back to a failure by elsa to handle an "offset out of range" error message that brod emits. This PR just adds handling and a few test cases including some integration tests against an actual kafka using the divo lib. This change does entail the possibility for lost or replayed messages (depending on your config) - but with a no longer valid offset you're left with only 2 choices: Reset to earliest, or reset to latest. I tried to make that clear in the inline doc.
Closes https://simplifi.atlassian.net/browse/DSP1-498