Repository navigation
fix(compat): raise three floors for Python 3.13 and newer - #113
Merged
Merged
Conversation
The oldest NumPy with wheels for Python 3.13 is 2.x, so the floors column failed there on every OS. These lines carry a python_version marker, so 3.12 still tests the declared floors. - xarray>=2023.9.0: older releases use np.unicode_, gone in NumPy 2 - pint>=0.24.4: up to 0.23 uses np.cumproduct; 0.24.0 to 0.24.3 fail on import - fsspec>=2024.10.0: older zip filesystems call Path.__enter__, gone in Python 3.13 Signed-off-by: Simon van Lierde <simonvanlierde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the compat
floorscolumn on Python 3.13 and 3.14, which failed on every OS. The oldest NumPy with wheels for 3.13 is 2.x, and three floors were too old for it or for Python 3.13 itself.xarray>=2023.9.0(bw2calc): up to 2023.8.0 usesnp.unicode_, which NumPy 2 removed.pint>=0.24.4(bw2data): up to 0.23 usesnp.cumproduct, and 0.24.0 to 0.24.3 fail on import with a frozen dataclass error.fsspec>=2024.10.0(bw_processing): up to 2024.9.0 the zip filesystem callsPath.__enter__, which Python 3.13 removed.python_version >= "3.13"marker, so 3.12 still tests the declared floors.Tests:
just compat 3.13 floors,just compat 3.14 floorsandjust compat 3.12 floorspass, as doestests/test_compat_sh.py.